I think at this point, Sepherosa Ziehau is able to improve the DragonFly network stack by just standing near his computer and concentrating for a few minutes. For example, he’s unearthed another improvement to connect rate/reduction of CPU usage.
3 Replies to “Yet another network optimization”
Comments are closed.
There are missing brackets or wrong indentation. Most likely wrong indentation.
+ if (ai != NULL)
+ error = udp_preattach(so, 0 /* don’t care */, ai);
+ if (error)
+ goto out;
+ else {
+ /* Post attach; do nothing */
+ }
hmm, s4 is correct.
I think it’s missing brackets after != NULL) myself.
Oh :)
Pretty accidental. But the effect is same :), it currently read:
int error = 0;
if (ai != NULL)
error = udp_preattach();
if (error) {
goto out;
} else {
/* comment */
}
I am fixing it now :)